Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe consolidate all of the runners into one? #6

Open
ian-h-chamberlain opened this issue Aug 10, 2023 · 0 comments
Open

Maybe consolidate all of the runners into one? #6

ian-h-chamberlain opened this issue Aug 10, 2023 · 0 comments

Comments

@ian-h-chamberlain
Copy link
Member

Instead of separate run_console, run_gdb etc., maybe we can just use all of them at once!

  • The socket runner will simply fail to connect to 3dslink if it's running in Citra or the --server flag wasn't used
  • Either gdbHioDevInit() or gdbHioDevRedirectStdStreams() should fail if running on hardware (or they are no-ops)
  • Console should basically always work, unless the test needs to own the screens / Gfx for some reason (in which case it should probably be an integration test, and we can control the features more carefully there).

The only oddity would be that none of them work simultaneously, so they would need to be in some kind of priority order. Maybe still have cargo features like this?

[features]
# These three output channels will be tried, in this order, to display test output.
# Failure to set up a given output stream will be ignored, so the last successful method
# will be the one ultimately used by the test. You can skip a certain method by disabling its
# corresponding feature.

default = ["console", "gdb", "socket"] # or maybe a different order/subset
console = []
gdb = []
socket = []
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant