cargo-apk: Print and follow adb logcat output after starting app
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
process linger in the background with the ability to emit more lines to stdout
|
@MarijnS95 I suspect the CI script to potentially require an update after this, but I'm not entirely sure. Looks like it got stuck as well after about ~5 hours. |
MarijnS95
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Good to have this by default, I added a --no-logcat option to back out of this, for example in the CI.
(We could/should also use the cargo apk run logcat output in CI to test if the right strings are printed, but there's currently no neat way to pass the -d option to logcat so that it exits pretty soon. At the same time that doesn't guarantee the app has properly reached the print statement, but the CI has always been running on good faith given that -W was never passed to am start either yet the app always started in time.)
MarijnS95
changed the title
adb logcat output after starting app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #331
This starts a logcat session for our PID so we have something that's a bit more akin to how
cargo runregularly works. If this is undesired, I would also be OK with adding a--logargument.