cargo-apk: Export native activity by default on Android S and up #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Mar 16, 2022
Similar to how we help the user with a default `MAIN` intent filter to launch the sole `NativeActivity` in their application (and setting a few other sensible defaults), we should also set Android's new `android:exported` attribute to `true` if they're targeting Android S (SDK 31) or higher. Without this set to `true` the Rust app is not allowed to be started externally (by ie. a launcher or `adb`) on Android S+, and with only a single `Activity` currently supported by `ndk-build` it is unlikely (but not impossible, see shared user IDs etc), that there are other means to start it internally. https://developer.android.com/guide/topics/manifest/activity-element#exported
MarijnS95
force-pushed
the
manifest-exported-attribute
branch
from
01c04db to
ec8cd39
Compare
dvc94ch
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #241
Subsumes #204
Similar to how we help the user with a default
MAINintent filter to launch the soleNativeActivityin their application (and setting a few other sensible defaults), we should also set Android's newandroid:exportedattribute totrueif they're targeting Android S (SDK 31) or higher.Without this set to
truethe Rust app is not allowed to be started externally (by ie. a launcher oradb) on Android S+, and with only a singleActivitycurrently supported byndk-buildit is unlikely (but not impossible, see shared user IDs etc), that there are other means to start it internally.https://developer.android.com/guide/topics/manifest/activity-element#exported