NOISSUE - Create Dockerfile: #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use cargo chef to reduce docker build times locally * Add .dockerignore Signed-off-by: joshmc <[email protected]>
|
Seems useful, let me look closer at cargo chef before merging. |
|
Sounds good! I found it extremely useful when developing some of my own projects, it does a great job of reducing build times for docker images. |
|
cargo chef seems like a nice improvement, let's merge this! Related upstream issue in cargo: rust-lang/cargo#2644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: joshmc [email protected]