ISSUE-16 - Construct cargo_geiger PackageId from a cargo_metadata #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcconnell26
commented
Nov 23, 2020
| "registry" => { | ||
| cargo_geiger_serde::Source::Registry { | ||
| // It looks like cargo metadata drops this information | ||
| name: String::from("crates.io"), |
There was a problem hiding this comment.
I'm unsure on this, it looks like it gets dropped by cargo_metadata, I'm not sure if we want to parse this from somewhere else (or even where we would parse it from)?
There was a problem hiding this comment.
I think the comment is good enough for now.
jmcconnell26
force-pushed
the
ISSUE-16-ConstructCargoSerdeIdFromCargoMetadataPackageId
branch
20 times, most recently
from
393cb47 to
f40b777
Compare
PackageId: * Add method to construct Source from cargo metadata * Add tests Source construction * Remove further usages of package set Signed-off-by: joshmc <[email protected]>
jmcconnell26
force-pushed
the
ISSUE-16-ConstructCargoSerdeIdFromCargoMetadataPackageId
branch
from
f40b777 to
6eb451e
Compare
|
This should now be ready to go, sorry about the delay, I had a wee bit of trouble with the paths in Windows. |
No problem, I'm taking my sweet time getting to reviewing as well it seems. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageId:
Signed-off-by: joshmc [email protected]