ISSUE-16 - Remove cargo core usage from graph module:

[jmcconnell26]

• Pull further structs from Args struct
• Add functions to krates_utils for replace and deps_not_replaced
  functions from resolve
• Add function for matches_ignoring_source
• Adding functions to extract the name and version of a cargo_metadata
  package from the PackageId
• Remove usage of cargo core from graph module

Signed-off-by: joshmc [email protected]

[jmcconnell26]

This is a work in progress.
I seem to be having issues with the tests for cargo-geiger-serde.
The output of cargo-geiger remains constant despite my changes, however passing the --json flag generates different output.
I have attached both the new and old output for the second test package here.
To me the new output actually looks correct, however I am unsure what the expected behaviour is.
@anderejd, @stephaneyfx, could you advise on what the correct output should be?
Thanks,
Josh

new.txt
old.txt

[stephaneyfx]

Hi Josh,

AFAICT the old output is correct. Every package in the dependency tree rooted at test2_package_with_shallow_deps should have its own entry in the packages array in the json report. The new report contains only the root package of the dependency tree.

Does that help?

[jmcconnell26]

Hi @stephaneyfx,

Ahh, I follow now, we aren't including any of the dependency information on the packages in the JSON report, that makes sense.
I'm not 100% why the changes I made caused this, but I'll take a look into this now.

Thanks for the response!
Josh

[jmcconnell26]

This PR is now ready for review. I was able to catch where I had gone wrong!
Thanks,
Josh