ISSUE-16 - Further refactoring #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split out scan modules further * Create custom_executor module * Simplify some functions and reduce unnecessary exposing of some functions/structs to the whole bin
anderejd
reviewed
Oct 4, 2020
Comment on lines
+12
to
+19
| pub fn emoji(&self, kind: SymbolKind) -> Box<dyn std::fmt::Display> { | ||
| let idx = kind as usize; | ||
| if self.will_output_emoji() { | ||
| Box::new(self.emojis[idx]) | ||
| } else { | ||
| Box::new(self.fallbacks[idx].clone()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Just curious, what's the motivation for moving this function? :)
EDIT: Sorting functions by name? If yes, then 👍
There was a problem hiding this comment.
Yes, exactly! I find it so much quicker to work with files where the functions are sorted by name
|
|
||
| // Is anyone using this? This is a carry-over from cargo-tree. | ||
| // TODO: Open a github issue to discuss deprecation. | ||
| pub format: &'a Pattern, | ||
| pub format: Pattern, |
There was a problem hiding this comment.
👍 eliminating unnecessary borrows, nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions/structs to the whole bin