Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some crates counted multiple times for the final tally #79

Closed
Shnatsel opened this issue Jan 8, 2020 · 3 comments
Closed

Some crates counted multiple times for the final tally #79

Shnatsel opened this issue Jan 8, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Shnatsel
Copy link

Shnatsel commented Jan 8, 2020

If a crate occurs multiple times in build dependencies, the number of unsafe blocks in it seems to be added multiple times to the final tally.

For example, release 0.11.3 of https://github.com/algesten/ureq totals 2574 unsafe expressions according to cargo-geiger 0.9.0, but that number doesn't align with the individual crate counts. It seems that ring with its 480 unsafe expressions is counted multiple times, otherwise there's no way to explain these results.

@anderejd anderejd added the bug Something isn't working label Jan 10, 2020
@anderejd
Copy link
Contributor

Thank you for the report! I will try to find some open source time in the coming weeks.

@anderejd
Copy link
Contributor

This bug should now be fixed in the latest master.

@anderejd
Copy link
Contributor

Released in 0.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants