-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iterator::choose_stable() #1057
Conversation
Thanks for taking care of this! I did not yet look at the code, but the documentation looks good. Maybe we should mention now in the docs of |
I added a hint about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I suggested some tweaks relating to 32/64-bit consistency and testing value stability.
b34ed44
to
bc81e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than a simple typo.
Could you rebase? #1056 should have fixed that test failure.
This function is similar to Iterator::choose() except that given a PRNG and any iterator of the same length it will always select the same element and make the same calls to the PRNG. Closes rust-random#1051
bc81e74
to
3126c7a
Compare
3126c7a
to
7ee6cd1
Compare
This function is similar to Iterator::choose() except that given a PRNG and any iterator of the same length it will always select the same element and make the same calls to the PRNG.
Closes #1051