Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GlobalDescriptorTable const generic #443

Closed
wants to merge 1 commit into from

Conversation

MechSlayer
Copy link

@MechSlayer MechSlayer commented Nov 14, 2023

To avoid breaking compatibility, renamed to BasicGlobalDescriptorTable, and made GlobalDescriptorTable be an alias with 8 entreis.

Went with the rename + alias approach due to this issue.

@phil-opp
Copy link
Member

Thanks for submitting and sorry for the long delay!

This looks good overall, but I'm not sure if I like the rename+alias approach. Another solution could be to use a default sie and implement the new and from_raw_slices only for GlobalDescriptorTable<8>. Then we could add separate methods for constructing tables with other sizes. This way, we should still be backwards compatible.

Alternatively, we could also accept the small breaking change and target the upcoming v0.15 release, which we wanted to publish for some quite some time.

@josephlr @Freax13 What do you think?

@Freax13
Copy link
Member

Freax13 commented Dec 27, 2023

This looks good overall, but I'm not sure if I like the rename+alias approach. Another solution could be to use a default sie and implement the new and from_raw_slices only for GlobalDescriptorTable<8>. Then we could add separate methods for constructing tables with other sizes. This way, we should still be backwards compatible.

If this works, I'd prefer this.

@Freax13 Freax13 mentioned this pull request Jan 14, 2024
4 tasks
@phil-opp
Copy link
Member

It turns out that we already merged a PR to make the GDT const generic in #360. This feature will be available once #446 is merged.

@MechSlayer Thanks for your contribution anyway and sorry for the chaos!

@phil-opp phil-opp closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants