Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Cr2::read_raw #334

Merged
merged 2 commits into from
Jan 17, 2022
Merged

add Cr2::read_raw #334

merged 2 commits into from
Jan 17, 2022

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Jan 16, 2022

This pr adds Cr2::read_raw.

Closes #332

@Freax13 Freax13 requested a review from phil-opp January 16, 2022 14:00
phil-opp
phil-opp approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

src/registers/control.rs Outdated Show resolved Hide resolved
@phil-opp phil-opp mentioned this pull request Jan 17, 2022
Merged
@Freax13 @phil-opp
improve doc comment
38537d1 
Co-authored-by: Philipp Oppermann <[email protected]>
@Freax13 Freax13 merged commit 5014113 into rust-osdev:master Jan 17, 2022
@Freax13 Freax13 deleted the cr2-read-raw branch January 17, 2022 10:51
phil-opp added a commit that referenced this pull request Feb 3, 2022
@phil-opp
Update changelog for #334 and #336
204e6e3
@phil-opp phil-opp mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call to VirtAddr::new() causes panic when CR2 does not contain a canonical address.
2 participants
@Freax13 @phil-opp