change cpu_flags's type to RFlags
#324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
@Freax13 thanks! I wasn't aware of bitflags/bitflags#188, which describes how "unknown" bits work with 1.2.0. I think this is a very reasonable change.
The docs for from_bits_unchecked also explain how the type has to decide if/when to allow "unknown" bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#262 mentions that we should use correct types for
InterruptStackFrameValue. This pr changescpu_flagsfrom u64 toRFlags, adds#[repr(transparent)]toRFlagsand upgrades thebitflagsdependency to the latest version. This last change is needed because "unknown" bits weren't officially supported until version1.2.0, starting with1.2.0crate authors must define what bit representations are valid for a type.