Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan for renaming asm! macro to llvm_asm! #140

Closed
phil-opp opened this issue Mar 26, 2020 · 1 comment · Fixed by #151
Closed

Plan for renaming asm! macro to llvm_asm! #140

phil-opp opened this issue Mar 26, 2020 · 1 comment · Fixed by #151
Labels
nightly breakage

Comments

@phil-opp
Copy link
Member

The change to rename the asm! macro to llvm_asm! was just approved in rust-lang/rust#68404, so I expect that it will be in tomorrow's nightly. As far as I understand it, the old asm! will continue to work for now, but deprecated soon.

To avoid breakage, I think it makes sense to make it a minor release to avoid breakage for people that pinned an older nightly. The deprecation period should then be enough time for users to switch to the new version
@phil-opp
Copy link
Member Author

The asm macro was now deprecated in rust-lang/rust#71007.

@haraldh haraldh mentioned this issue Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nightly breakage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use llvm_asm! instead of deprecated asm! macro
1 participant
@phil-opp