Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo warning about publish-lockfile feature when compiling #57

Closed
luojia65 opened this issue Jun 19, 2019 · 1 comment · Fixed by #62
Closed

Cargo warning about publish-lockfile feature when compiling #57

luojia65 opened this issue Jun 19, 2019 · 1 comment · Fixed by #62

Comments

@luojia65
Copy link

luojia65 commented Jun 19, 2019

Hello! When I test an handwritten OS following the toturial Writing an OS in Rust, the test is successful, but there is a warning on configuration when building the bootloader. Here's my console output:

PS D:\RustProjects\spicy_os> cargo xtest
   Compiling spicy_os v0.1.0 (D:\RustProjects\spicy_os)
    Finished dev [unoptimized + debuginfo] target(s) in 0.38s
     Running target\x86_64-spicy_os\debug\deps\spicy_os-990499773c553c1e
Building bootloader
warning: The `publish-lockfile` feature is deprecated and currently has no effect. It may be removed in a future version.
   Compiling bootloader v0.6.0 (C:\Users\luojia65\.cargo\registry\src\mirrors.ustc.edu.cn-61ef6e0cd06fb9b8\bootloader-0.6.0)
    Finished release [optimized + debuginfo] target(s) in 1.88s
Running: `qemu-system-x86_64 -drive format=raw,file=D:\RustProjects\spicy_os\target\x86_64-spicy_os\debug\deps\bootimage-spicy_os-990499773c553c1e.bin -device isa-debug-exit,iobase=0xf4,iosize=0x04 -serial stdio -display none

According to this warning, cargo feature publish-lockfile has currently no effect. It looks like this is related to the piece of code here. Would it be possible to remove this cargo feature configuration, or do another way to fix this warning?

Here's my Rustup and Rustc version:

C:\Users\luojia65>rustup -V
rustup 1.18.3 (435397f48 2019-05-22)

C:\Users\luojia65>rustc -V
rustc 1.35.0 (3c235d560 2019-05-20)
@phil-opp
Copy link
Member

Thanks for reporting! The publish-lockfile feature was recently removed in rust-lang/cargo#7026. So yes, removing the cargo feature should fix the warning. However, I think we should wait for a bit (about a week or so) before removing the feature to give people that rely on the publish-lockfile feature time to update their nightlies.

bors bot added a commit that referenced this issue Jul 7, 2019
62: Remove stabilized publish-lockfile feature r=phil-opp a=phil-opp

The feature was stabilized/removed in rust-lang/cargo#7026. Now all binaries include the Cargo.lock by default.

Fixes #57

Co-authored-by: Philipp Oppermann <[email protected]>
@bors bors bot closed this as completed in #62 Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants