Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert netlink-packet-core bump to 0.7 in 0.11.z release #16

Open
nox opened this issue Jul 10, 2023 · 3 comments
Open

Revert netlink-packet-core bump to 0.7 in 0.11.z release #16

nox opened this issue Jul 10, 2023 · 3 comments

Comments

@nox
Copy link

nox commented Jul 10, 2023

Bumping netlink-packet-core from 0.5 to 0.7 is a breaking change because netlink-packet-core is part of the public API of netlink-proto. It should thus be bumped as part of a major release of netlink-proto, i.e. netlink-proto 0.12.

Users cannot build rtnetlink 0.12 anymore because it depends on netlink-packet-core 0.5 and netlink-proto 0.11, and items from netlink-packet-core 0.5 cannot be used with netlink-proto 0.11.2 anymore.

@dignifiedquire
Copy link

Running into the same issues, breaking dependencies for me

@ydirson
Copy link

ydirson commented Sep 13, 2023

Same here

@ydirson
Copy link

ydirson commented Sep 13, 2023

Note the issue can be worked around by pinning netlink-proto to 0.11.1 (or bumping all netlink crates), but it's just a workaround

ydirson added a commit to ydirson/xen-guest-agent that referenced this issue Sep 13, 2023
This file holds tested versions of dependencies.  Notably, a breaking
change without proper version bump in a netlink crate shows the limits
of not shipping locked dependencies.

See rust-netlink/netlink-proto#16
ydirson added a commit to ydirson/xen-guest-agent that referenced this issue Sep 13, 2023
The rust-netlink/netlink-proto#16 blunder
forces to update all rust-netlink crates past netlink-proto 0.11.1, to
avoid a mix of different netlink-packet-core versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants