Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayView as Custom DST #538

Closed
jturner314 opened this issue Nov 12, 2018 · 2 comments
Closed

ArrayView as Custom DST #538

jturner314 opened this issue Nov 12, 2018 · 2 comments

Comments

@jturner314
Copy link
Member

It would be really nice if we could replace ArrayView/ArrayViewMut with custom dynamically-sized types. RFC 2594 is a current proposal for custom DSTs. The current version would work for const-dimensionality views but not for dynamic-dimensionality views (IxDyn).

I've asked about the dynamic dimensionality case and proposed a couple of ideas. @bluss Maybe you have some more ideas?

@bluss
Copy link
Member

bluss commented Sep 18, 2019

Just to note, it seems like the dynamic dimensional kind of view can never be a DST (due to the dynamic size and heap allocation of the metadata i.e the sizes and strides). That doesn't have to stop us from pursuing the rest.

@akern40
Copy link
Collaborator

akern40 commented Oct 30, 2024

While this is very clearly the dream, custom DSTs were postponed in 2021 and there's not even a mention of them on the 2024 roadmap. With #879 coming in, we at least alleviate some of the pressure for DSTs and there's a clear path forward for unifying ArrayView(Mut) with ArrayRef if custom DSTs pop their heads back up.

@akern40 akern40 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants