Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to thiserror from failure #101

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Switch to thiserror from failure #101

wants to merge 3 commits into from

Conversation

LoganDark
Copy link

Fixes #94

@NoraCodes NoraCodes added this to the 1.0 Release milestone Aug 29, 2020
@NoraCodes NoraCodes added c-bug Bug - some feature is not working as expected k-dependencies Issues with the crate's dependencies labels Aug 29, 2020
@LoganDark
Copy link
Author

In my opinion it would be better to get this out of the way sooner rather than later. Even though this may technically break builds for some, this is way better than failure and isn't worth pushing to 1.0 just because it breaks a small part of the API. Your API consumers will thank you :D

TL;DR Rapid prototyping go brr, no need to be that cautious just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c-bug Bug - some feature is not working as expected k-dependencies Issues with the crate's dependencies
Projects
None yet
Milestone
1.0 Release
Development

Successfully merging this pull request may close these issues.

Move away from failure
2 participants
@LoganDark @NoraCodes