Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to meson build #70

Open
MOZGIII opened this issue Apr 20, 2019 · 5 comments
Open

Switch to meson build #70

MOZGIII opened this issue Apr 20, 2019 · 5 comments
Labels
c-enhancement New feature or request k-buildprocess Issues with building the crate

Comments

@MOZGIII
Copy link

MOZGIII commented Apr 20, 2019

libui switched from cmake to meson, so this project should keep up.

I decided to create this - a tracking issue on thoughs and desired features for that change.

While switching to meson build system, it would be great to have support for the following things, or at least keep them in mind:

  1. The ability to control whether to build a static or dynamic lib. Apparently, the recommended way of doing that is via build-time env vars, and not via cargo features.
  2. The ability to embed custom manifests on windows.

Thoughts?

@NoraCodes NoraCodes added c-enhancement New feature or request k-buildprocess Issues with building the crate labels May 8, 2019
@MOZGIII
Copy link
Author

MOZGIII commented Jul 30, 2019

https://github.com/MOZGIII/libui-sys - I'll just leave it here...

@mqudsi
Copy link

mqudsi commented Dec 12, 2019

Meson has a hard dependency on python3 that is never going away; something to keep in mind.

@MOZGIII
Copy link
Author

MOZGIII commented Dec 12, 2019

I've implemented libui-sys that's compatible with ui-rs from this repo. This libui-sys implementation is not a fork, built from scratch, but is a drop-in replacement for the ui-sys that this repo hosts. I also have a fork of libui-rs - that is patched to use my libui-sys crate.

I'd be happy to integrate my changes back if there's an interest from the community. For now, I'm just using those myself in my rebootinto project.

@phase
Copy link

phase commented Mar 25, 2020

@MOZGIII's fork worked perfectly for me! I would love to see this merged in.

@xobs xobs mentioned this issue Apr 5, 2020
4 tasks
@xobs
Copy link
Contributor

xobs commented Apr 5, 2020

I just saw this issue now.

I put together #86 that does away with the libui build system entirely and directly includes the source files by building them using cc-rs. So far I've tested it on Windows (MSVC) and Unix (Ubuntu 16.04).

It's simple enough to pull out a list of files to include, and the approach I've taken could be adapted to integrate with the newer meson build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-enhancement New feature or request k-buildprocess Issues with building the crate
Projects
None yet
Development

No branches or pull requests

5 participants