ndk/native_window: Add missing function wrappers #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Aug 22, 2023
| /// codec, this call has no effect. | ||
| /// | ||
| /// You can register for changes in the refresh rate using | ||
| /// [`ffi::AChoreographer_registerRefreshRateCallback()`]. |
There was a problem hiding this comment.
For the frame rate I'm considering also binding AChoreographer soon™.
MarijnS95
force-pushed
the
ndk-native-window-missing-apis
branch
from
4c94437 to
effd4f5
Compare
MarijnS95
force-pushed
the
ndk-native-window-missing-apis
branch
from
effd4f5 to
af3ab12
Compare
MarijnS95
commented
Aug 31, 2023
| @@ -13,7 +13,7 @@ repository = "https://github.com/rust-mobile/ndk" | |||
| rust-version = "1.64" | |||
|
|
|||
| [features] | |||
| all = ["audio", "bitmap","media", "api-level-30"] | |||
| all = ["audio", "bitmap","media", "api-level-31"] | |||
There was a problem hiding this comment.
Looks like I forgot this in #428.
MarijnS95
force-pushed
the
ndk-native-window-missing-apis
branch
from
af3ab12 to
0fcef2a
Compare
MarijnS95
force-pushed
the
ndk-native-window-missing-apis
branch
3 times, most recently
from
b867105 to
9a07733
Compare
This was added to the NDK with API level 26 but never made it to Rust. Allows the user to apply mirror and rotation effects.
MarijnS95
force-pushed
the
ndk-native-window-missing-apis
branch
2 times, most recently
from
cb969f2 to
7279787
Compare
MarijnS95
force-pushed
the
ndk-native-window-missing-apis
branch
from
7279787 to
3562d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_buffers_transform()APItry_allocate_buffers()APIset_frame_rate*()APIs since level 30/31Note that this lacks
ANativeWindow_readFromParcel/writeToParcelwhich'll only appear in API level 34 with R26 which is still in beta. Besides, we don't yet bindAParceleither.