ndk-build: Switch NDK r23 -lgcc workaround to CARGO_ENCODED_RUSTFLAGS env var for paths with spaces
#298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
ndk-r23-workaround-support-spaces
branch
from
b53978c
to
453a525
Compare
…AGS` env var for paths with spaces
On Windows user paths usually include people's full name, with a space.
If they have their Rust project somewhere in their user profile `cargo`
fails to parse the workaround path:
process didn't exit successfully: `rustc - --crate-name ___ --print=file-names -L '"C:\Users\Bla' 'Haj\Desktop\Breda\target\cargo-apk-temp-extra-link-libraries"' ... (exit code: 1)
As per the [documentation for `RUSTFLAGS`] its contents are split by a
very simple `.split(" ")` algorithm without caring for quotation
delimiters or escape characters. To retain backwards compatibility this
has been implemented in a new environment variable named
`CARGO_ENCODED_RUSTFLAGS`, which separates by ASCII Unit Separators
(`0x1f`) instead.
[documentation for `RUSTFLAGS`]: https://doc.rust-lang.org/cargo/reference/environment-variables.html
MarijnS95
force-pushed
the
ndk-r23-workaround-support-spaces
branch
from
453a525
to
9438a9d
Compare
|
I'll merge this after adding some space-testing in the CI and seeing it fail first :) |
|
I'd need to make too many changes to the CI to test paths with spaces, not going to bother now. And have some other work built on top of this PR, merging it now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows user paths usually include people's full name, with a space. If they have their Rust project somewhere in their user profile
cargofails to parse the workaround path:As per the documentation for
RUSTFLAGSits contents are split by a very simple.split(" ")algorithm without caring for quotation delimiters or escape characters. To retain backwards compatibility this has been implemented in a new environment variable namedCARGO_ENCODED_RUSTFLAGS, which separates by ASCII Unit Separators (0x1f) instead.