cargo-apk,ndk-build: Move NDK r23 -lgcc workaround to cargo_ndk to reuse in -- subcommand
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2022
…o reuse in `--` subcommand Winit is currently being hit by `-lgcc not found` linker errors because GH Actions' [virtual-environments recently migrated to Android NDK r23], and it turns out it's using the niche `--` subcommand to invoke regular `cargo` commands under an NDK environment. The workaround using `RUSTFLAGS` is only patched into the `build()` command; by moving it into our `cargo_ndk()` environment preparation function this workaround is universally available and usable. Note that this is a breaking change, we're changing the API signature of `ndk-build`. [virtual-environments recently migrated to Android NDK r23]: actions/runner-images#5595
MarijnS95
force-pushed
the
move-lgcc-workaround-to-ndk-build
branch
from
4c96a28 to
4dd596d
Compare
msiglreith
approved these changes
Jun 10, 2022
|
seems to work locally with ndk-r24 👍 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winit is currently being hit by
-lgcc not foundlinker errors because GH Actions' virtual-environments recently migrated to Android NDK r23, and it turns out it's using the niche--subcommand to invoke regularcargocommands under an NDK environment.The workaround using
RUSTFLAGSis only patched into thebuild()command; by moving it into ourcargo_ndk()environment preparation function this workaround is universally available and usable.Note that this is a breaking change, we're changing the API signature of
ndk-build.