Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap video coding APIs #180

Closed
wants to merge 1 commit into from
Closed

Wrap video coding APIs #180

wants to merge 1 commit into from

Conversation

zmerp
Copy link
Contributor

@zmerp zmerp commented Aug 28, 2021

Add support for AMediaCodec to ndk-sys. I tried to generate the bindings but I was not able to.

@MarijnS95
Copy link
Member

MarijnS95 commented Aug 28, 2021

Thanks for your contribution @zarik5! I have a similar change queued up, with regenerated bindings, to be published after #178 is merged.

Are you planning to add support for MediaCodec in the safe ndk bindings?

@zmerp
Copy link
Contributor Author

zmerp commented Aug 28, 2021

No I don't have plans for now, I don't feel experienced enough with Android to write a safe wrapper.

@MarijnS95
Copy link
Member

No I don't have plans for now, I don't feel experienced enough with Android to write a safe wrapper.

Ah, so just using the raw bindings.

You can find a regenerated ndk-sys here: https://github.com/MarijnS95/android-ndk-rs/tree/more-sys

@zmerp
Copy link
Contributor Author

zmerp commented Aug 28, 2021

You can find a regenerated ndk-sys here: https://github.com/MarijnS95/android-ndk-rs/tree/more-sys

Oh thank you!

@zmerp
Copy link
Contributor Author

zmerp commented Aug 28, 2021

Since you already took care of it I'll close this PR.

@zmerp zmerp closed this Aug 28, 2021
@zmerp
Copy link
Contributor Author

zmerp commented Nov 22, 2021

@MarijnS95 Do you still plan to merge your more-sys branch into the upstream repository?

@MarijnS95
Copy link
Member

@zarik5 Are you still planning to rework https://github.com/alvr-org/ALVR/blob/master/alvr/experiments/client/src/video_decoder/mediacodec.rs into a wrapper for submission to android-ndk-rs?

If so I can probably see about rebasing and submitting that branch.

@zmerp
Copy link
Contributor Author

zmerp commented Nov 22, 2021

@zarik5 Are you still planning to rework https://github.com/alvr-org/ALVR/blob/master/alvr/experiments/client/src/video_decoder/mediacodec.rs into a wrapper for submission to android-ndk-rs?

Not really for now, but I think there would still value in having the raw MediaCodec API in the ndk-sys crate. I'm not excluding I will contribute the safe bindings in the future 🙂. Continuing using your fork is workable but a bit inconvenient since it's getting old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants