Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extract_native_libs value to steer library compression #32

Open
MarijnS95 opened this issue Sep 11, 2023 · 0 comments
Open

Use extract_native_libs value to steer library compression #32

MarijnS95 opened this issue Sep 11, 2023 · 0 comments

Comments

@MarijnS95
Copy link
Member

MarijnS95 commented Sep 11, 2023

# See https://developer.android.com/guide/topics/manifest/application-element#extractNativeLibs
extract_native_libs = true

In hindsight we should have also used this property to steer whether libs are compiled in the APK:

if self.config.disable_aapt_compression {
aapt.arg("-0").arg("");
}

Per the documentation linked for this property, libraries are stored uncompressed when they are not extracted by the installer. Right now I think one can create an invalid APK when setting extract_native_libs = false and building a non-debug (release) profile, which sets disable_aapt_compression = false:

disable_aapt_compression: is_debug_profile,

Originally posted by @MarijnS95 in #15 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant