Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact on build scripts that invoke rustc #50

Closed
jdm opened this issue Oct 10, 2019 · 3 comments
Closed

Impact on build scripts that invoke rustc #50

jdm opened this issue Oct 10, 2019 · 3 comments
Labels
S-needs-design Status: needs design work stabilization blocker This needs a resolution before stabilization

Comments

@jdm
Copy link

jdm commented Oct 10, 2019

While experimenting with how to build Servo for targets where libstd is not available through rustup, I've been exploring whether the new -Z build-std is enough. This has led me to discover rust-lang/cargo#7501 (via cuviper/autocfg#12), so I want to make sure that the people working on this feature consider the interaction of it with build scripts that need to perform their own rustc invocations.

@ehuss ehuss added plan before stabilization This needs a plan for how to address before stabilization, but does not need to be implemented. stabilization blocker This needs a resolution before stabilization S-needs-design Status: needs design work and removed plan before stabilization This needs a plan for how to address before stabilization, but does not need to be implemented. labels May 3, 2023
@epage
Copy link

epage commented Aug 30, 2024

In rust-lang/cargo#11244, I questioned whether we should go out of our way to support build probes or if we should instead direct people to

  • cfg_accessible
  • crates providing opt-ins for nightly features.

@epage
Copy link

epage commented Aug 30, 2024

@epage
Copy link

epage commented Sep 3, 2024

Closing for similar reason as rust-lang/cargo#11244

We talked about this in today's cargo meeting. The use cases seem to be focused on build probes. We are not inclined to add features specifically for build probes at this time but would instead encourage use of

* `cfg(accessible)` and `cfg(version)` where possible (interest from t-lang to stabilize, just needs a champion to check it over and drive stabilization)

* `features` everywhere else (or maybe even [global features](https://internals.rust-lang.org/t/pre-rfc-mutually-excusive-global-features/19618)), including enabling of nightly features

While cfg(accessible), cfg(version), and global features would involve MSRV bumps, I suggest considering whether the soon-to-stabilize MSRV-aware resolver might be sufficient to re-evaluate an MSRV policy in light of a feature like this. For a foundational package, one could bump minor and leave room for critical patches of old versions while allowing new versions to use these features.

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-design Status: needs design work stabilization blocker This needs a resolution before stabilization
Projects
None yet
Development

No branches or pull requests

3 participants