Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Remove vscode-Rust from the vs-code marketplace #927

Closed
branrickman opened this issue Sep 30, 2021 · 23 comments
Closed

Remove vscode-Rust from the vs-code marketplace #927

branrickman opened this issue Sep 30, 2021 · 23 comments

Comments

@branrickman
Copy link

branrickman commented Sep 30, 2021

Or at least add text to the extension description pointing people to rust-analyzer.

This project is not currently active, but it still sits on the top of the vscode marketplace. It is tripping up fresh would-be rust programmers (until they happen to hear by word of mouth that rust-analyzer is what they should be using).

Not a dig at anyone, I have huge respect for tool builders, but it is harming the community by adding a pretty big trap for new users.

@branrickman branrickman changed the title Remove vscode-Rust from the marketplace Remove vscode-Rust from the vs-code marketplace Sep 30, 2021
@Noxdor
Copy link

Noxdor commented Oct 26, 2021

This is actually exactly what I run in (programming rust since about 2 weeks). I just wanted to post an issue I'm having with the official rust extension and so only discovered by accident that there is a better alternative with the rust-analyzer extension.
I wouldn't go that far to say this is a huge problem for newbies, because the rust extension is doing a fine job for learning the basic concepts, but I now run into problems looking into the embedded world.

@Xanewok
Copy link
Member

Xanewok commented Oct 26, 2021

I'll work on it in the following weeks, sorry for that.

@joaomoreno
Copy link

I just hit this trap. And I work in VS Code. I'll make some calls.

@computerquip
Copy link

computerquip commented Oct 30, 2021

Also just ran into this. In particular, this is still the "recommended" plugin for rust in vs-code. I don't know if removing it is that big of a deal but at least getting it off the recommendation list for rust would be nice.

@yuhr
Copy link

yuhr commented Nov 3, 2021

In my case rust-analyzer extension does not work well (underline warnings & errors don't show up in my code), while this extension just works. Please don't remove.

@lnicola
Copy link
Member

lnicola commented Nov 3, 2021

@yuhr please file a GitHub issue on the rust-analyzer repo.

@yuhr
Copy link

yuhr commented Nov 3, 2021

@lnicola But what's the status of this extension? If it's officially in maintenance mode, I'd gladly go for rust-analyzer as you said, but in my case everything's going well with this extension for now.

@lnicola
Copy link
Member

lnicola commented Nov 3, 2021

@yuhr rust-analyzer is currently developed independently, but has been accepted as the successor of RLS in https://rust-lang.github.io/rfcs/2912-rust-analyzer.html.

It's less precise than RLS, but arguably more actively maintained and a lot of users are quite happy with it.

@yuhr
Copy link

yuhr commented Nov 3, 2021

@lnicola Thanks for letting me know that. I'll try to take a look into why it doesn't work for my project

@kkaja123
Copy link

An official extension deprecation feature should be coming in the May 2022 release of VSCode: microsoft/vscode#4772

@isidorn
Copy link

isidorn commented Jun 1, 2022

Hi VS Code PM here 👋

I just marked the Rust extension as deprecated in favour of the rust-analyzer one

This should make it clearer for new users. If the extension authors of the old Rust extension do not agree with this please reach out and we can easily change this. Thanks

To make it clear we will not auto migrate the existing rust-lang users. We will render a button in the extension view to make this convenient for users.

fyi @lnicola

Screenshot 2022-06-01 at 19 08 46

@Xanewok
Copy link
Member

Xanewok commented Jun 1, 2022

No, that's great. Thank you so much for your help!

@yankeeinlondon
Copy link

I want to remove this extension but the UI offers no option to uninstall. I am using rust-analyzer and have for a long while but I'm concerned that this deprecated extension might cause issues and would prefer to just remove it.

@lnicola
Copy link
Member

lnicola commented Oct 10, 2022

@yankeeinlondon I think you can nuke it from ~/.vscode/extensions (or somewhere under %APP_DATA% on Windows).

@yankeeinlondon
Copy link

Hmmm. I tried to find it with ls ~/.vscode/extensions | grep rust and got:

rust-lang.rust-analyzer-0.3.1229-darwin-x64
rust-lang.rust-analyzer-0.4.1236-darwin-x64
rust-lang.rust-analyzer-0.4.1237-darwin-x64
swellaby.vscode-rust-test-adapter-0.11.0

and I believe what i should have seen is rust-lang.rust right?

@lnicola
Copy link
Member

lnicola commented Oct 10, 2022

You have the new extension (or three versions of it, some possibly almost empty). I don't see the old extension there. Does it still show up as installed?

@yankeeinlondon
Copy link

yeah it does but I do see the deprecated notice too:

image

@yankeeinlondon
Copy link

note: i am using tracing which still needs the nightly analyzer to not produce errors on some of the macros

@lnicola
Copy link
Member

lnicola commented Oct 10, 2022

Yeah, I'm not sure where that extension is coming from. Are you using the sync feature of Code?

Re. nightly, the latest stable RA (from today) is the same as the nightly one. It (mostly) doesn't matter of your code is using nightly features or not, i.e. a stable RA will support the same set of nightly features as the nightly one.

@yankeeinlondon
Copy link

yankeeinlondon commented Oct 10, 2022

apparently the proc macro instrument() which was broken some while ago and was still broken at least as of yesterday in RA was actually fixed several months ago but hadn't made it into the stable release yet so I figured I'd move but I'd prefer to move back to stable when I can. You think today's release get's me there?

WRT to using sync ... I am using it.

@lnicola
Copy link
Member

lnicola commented Oct 10, 2022

RA has a stable release every Monday. In addition, it lands in rustup (on the nightly toolchain) every Wednesday or so, where it follows the usual release train and hits stable in up to six weeks. There are no backports.

If you're using the Code extension without an explicit server path, you get the one that's updated weekly. If you use the nightly extension, you get daily updates. The Monday releases are identical to the previous nightlies.

@yankeeinlondon
Copy link

Ok well that's good to know and makes some sense; i had read that this was fixed months ago on nightly but wasn't sure how it had missed making it to stable. Guess maybe the messenger was wrong about that.

@lnicola
Copy link
Member

lnicola commented Oct 14, 2022

Yeah, "stable" is ambiguous, as it can either be the rustup component in the stable (which you probably don't want to use with VS Code) or the weekly RA release.

My gut feeling is that your issue is related to the synchronization feature of Code, but I've never used it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants