Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support manual r? without automatic reviewer assignment #1806

Open
RalfJung opened this issue May 3, 2024 · 2 comments
Open
Labels
A-assign-PR Area: PR auto assignment and welcome messages

Comments

@RalfJung
Copy link
Member

RalfJung commented May 3, 2024

In Miri we generally don't use automatic reviewer assignment, instead one of us just grabs a PR when something still needs review. It would still be nice to be able to use r? though. So it would be nice if triagebot could let us use r? without automatically assigning someone to every new PR.

@apiraino
Copy link
Contributor

apiraino commented May 3, 2024

@RalfJung ok so basically disable automatic assignment when a new PR with A-miri label is created, correct? There are also a number of labels in the same area (A-mir*). Should they be ignored as well?

EDIT: Or are you talking about the rust-lang/miri repository, don't you? So the rule should be: don't autoassign PRs for that repo?

@RalfJung
Copy link
Member Author

RalfJung commented May 3, 2024

This is for PRs in https://github.com/rust-lang/miri/, so no there's no label involved. I am just looking for a way to say in triagebot.toml that we want to support r? but not have anyone automatically assigned.

EDIT: Or are you talking about the rust-lang/miri repository, don't you? So the rule should be: don't autoassign PRs for that repo?

Yes, that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-assign-PR Area: PR auto assignment and welcome messages
Projects
None yet
Development

No branches or pull requests

3 participants