Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unknowable trait ref ambiguity candidate can be ignored if an always applicable candidate exists #66

Closed
lcnr opened this issue Oct 4, 2023 · 1 comment
Closed

unknowable trait ref ambiguity candidate can be ignored if an always applicable candidate exists #66

lcnr opened this issue Oct 4, 2023 · 1 comment

Comments

@lcnr
Copy link
Contributor

lcnr commented Oct 4, 2023

We add an ambiguous candidate for unknowable trait refs. However, unlike in the old solver, we return Certainty::YES if there is another candidate with no constraints. Given that projection goals always have constraints it feels like this should not impact coherence/the implicit negative overlap check.

TODO(@lcnr): thinky think
@lcnr
Copy link
Contributor Author

lcnr commented Sep 27, 2024

no longer applicable due to rust-lang/rust#129896

@lcnr lcnr closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lcnr