-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement all MSA Intrinsics #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a thorough review, but two things stand out:
- the msa module should use newtype vector types instead of re-exporting the ones from the
simd
module - this is not built in CI AFAICT, so this will need at least CI that builds with
msa
enabled (a qemu build job that runs the tests on CI can be added in a subsequent PR though)
This is looking really good, thank you for working on this. Do you think you would be able to add a couple of buildjobs that build the library with |
@gnzlbg Can I repurpose existing MIPS buildjobs for that or do I need to add new ones? |
You can repurpose them, by adding a case for mips here (https://github.com/rust-lang-nursery/stdsimd/blob/master/ci/run.sh#L64) and then enabling MSA. I think you might want to add new build jobs for the new |
Rustc changes which provide mips r6 support have been recently added (1.35-nightly). I don't think there is rustup target for mipsisa64r6*-unknown-linux-gnuabi64 available. |
@rbirdic rustup is not required, you can use xargo to recompile core for those targets, the |
@rbirdic in ci/run.sh, you seem not taking care about r6: |
@wzssyqa a |
So this looks good enough to merge for me. Build jobs for the |
How soon do you need these intrinsics on nightly Rust? I would be more comfortable if we were to set up running the run-time tests on CI before landing these upstream. |
I am ok with adding test first. |
Fixes #170