Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdsimd feature to allow_internal_unstable attribute in feature detect macros #1303

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

yaahc
Copy link
Member

@yaahc yaahc commented Apr 26, 2022

This is a blocker for rust-lang/rust#95956

That PR modifies the stability checking logic of rustc so that it additionally checks the stability of the path segments used to name an item, rather than only checking the stability of the item itself. This is necessary to allow std::error::Error to be moved into a new unstable core::error module while still being available on stable via a re-export in the stable std::error module.

That change breaks the feature detection macros since they start encountering the stdsimd unstable feature which is not explicitly mentioned in those macros allow_internal_unstable attribute.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@yaahc yaahc changed the title allow stdsimd feature in macros Add stdsimd feature to allow_internal_unstable attribute in feature detect macros Apr 26, 2022
@yaahc
Copy link
Member Author

yaahc commented Apr 26, 2022

no idea what's up with that test failure...

@ChrisDenton
Copy link
Member

ChrisDenton commented Apr 27, 2022

This is probably caused by rust-lang/rust#95604, which lead to some issues with stdcall symbol name mangling. The potential fix is rust-lang/rust#96444

@Amanieu Amanieu merged commit aaba990 into rust-lang:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants