Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CommandError::ExecutionFailed to optionally include stderr #91

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 11, 2024

since rust-lang/docs.rs#2467 we are now also seeing pre-build errors in docs.rs.

Some of the errors need more details for crate authors to work with them, example issues:

( there are more, but these examples should suffice )

With this change we now extend CommandError::ExecutionFailed and the necessary PrepareError variants with the captured stderr output, which should give crate authors all the information they need.

@syphar syphar force-pushed the exit-code-with-error branch 4 times, most recently from 0cd97b3 to 5ce9469 Compare October 13, 2024 08:11
@syphar syphar changed the title draft PR to run tests (capture stderr for commanderror) @syphar Extend CommandError::ExecutionFailed to optionally include stderr Oct 13, 2024
@syphar syphar changed the title @syphar Extend CommandError::ExecutionFailed to optionally include stderr Extend CommandError::ExecutionFailed to optionally include stderr Oct 13, 2024
@syphar syphar marked this pull request as ready for review October 13, 2024 08:37
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks!

@syphar syphar merged commit 1ed0d34 into rust-lang:master Oct 13, 2024
5 checks passed
@syphar syphar deleted the exit-code-with-error branch October 13, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants