Extend CommandError::ExecutionFailed to optionally include stderr #91
+77
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since rust-lang/docs.rs#2467 we are now also seeing pre-build errors in docs.rs.
Some of the errors need more details for crate authors to work with them, example issues:
( there are more, but these examples should suffice )
With this change we now extend
CommandError::ExecutionFailed
and the necessaryPrepareError
variants with the captured stderr output, which should give crate authors all the information they need.