winget upgrade for rustup is broken

[remidebette]

Problem

Hi, thank you for the nice tool.

I am installing rustup with winget, which is becoming the de facto tool for managing packages in Windows.

❯ winget install --id Rustlang.Rustup

My issue is that to this date I cannot seamlessly use the upgrade function of winget due to rustup not been upgraded by the tool:

❯ winget upgrade --id Rustlang.Rustup
This package's version number cannot be determined. To upgrade it anyway, add the argument --include-unknown to your previous command.

Adding the --include-unknown parameter is not a good solution because I am never not in a state where the system is 'up to date'

Steps

You can see the main reason is that winget is unable to detect the current version of rustup:

❯ winget upgrade --include-unknown
Name                                 Id                        Version Available Source
---------------------------------------------------------------------------------------
Rustup: the Rust toolchain installer Rustlang.Rustup           Unknown 1.25.1    winget

Possible Solution(s)

Expected Behavior:
The actual version of the currently installed version should appear as so:

❯ winget upgrade --include-unknown
Name                                 Id                        Version Available Source
---------------------------------------------------------------------------------------
Rustup: the Rust toolchain installer Rustlang.Rustup           1.25.1  1.25.1    winget

Additional context:
As explained here: microsoft/winget-cli#1356
The version used by winget is simply the information provided from Control Panel
Apparently, all that is needed is to add a DisplayVersion key in the registry when installing.

See how the Control panel does not see the version:

Here is an example of a program with a version:

Notes

No response

Rustup version

any version

currently I am using 1.25.1

Installed toolchains

Default host: x86_64-pc-windows-msvc

stable-x86_64-pc-windows-msvc (default)
rustc 1.64.0 (a55dd71d5 2022-09-19)

[fbstj]

microsoft/winget-pkgs#67393 is a corresponding issue in the repository

[remidebette]

So this should already be solved by #3047, provided the new version is correctly referenced in the winget registry?

Which version of rustup is expected to have the fix by the way?

[schlamar]

Not the current one, as this predates the fix

>rustup --version
rustup 1.25.1 (bb60b1e89 2022-07-12)

So this should be fixed with the next rustup release I guess.

[Rustin170506]

So this should be fixed with the next rustup release I guess.

Yes, I think it would be fixed in the next release. Fixed by #3047

[anarelion]

Also, we need to provide proper stable URLs for downloads: See microsoft/winget-pkgs#95599

[gotounix]

So this should be fixed with the next rustup release I guess.

Yes, I think it would be fixed in the next release. Fixed by #3047

@hi-rustin Is it not fixed in the next version 1.25.2 ?

[Rustin170506]

@hi-rustin Is it not fixed in the next version 1.25.2 ?

It does not. Because 1.25.2 is just a quick fix for a security issue.

[Rustin170506]

1.26.0 was released. I suppose this issue should be fixed. I am going to close this issue and if you have more questions please feel free to comment.

[fbstj]

indeed v1.26.0 has worked for me