fix(install): protect path with whitespaces using quotes #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpwxf
force-pushed
the
fix-installation-path
branch
from
510abf4
to
e6813f9
Compare
hpwxf
force-pushed
the
fix-installation-path
branch
from
e6813f9
to
d114847
Compare
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
…ion-path fix(install): protect path with whitespaces using quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing rustlings in a directory that contains whitespaces (not common, but possible),
install.shfails improperly.The script tries to continue the process even if a command has failed.
My proposal is:
set -euo pipefailto stop at the first error (error, undefined variable or pipe failure)