Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clap deprecations #6101

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Feb 29, 2024

Run cargo check --features clap/deprecated and fix all warnings

Run 'cargo check --features clap/deprecated' and fix all warnings
Comment on lines -212 to +213
app.after_help("")
.write_help(&mut io::stderr())
.expect("failed to write to stderr");
let help = app.after_help("").render_help();
eprintln!("{help}");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here (i guess) is enough newlines written.

Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

Confirming that I ran cargo check --features clap/deprecated as suggested and saw the deprecation warnings, and after testing this branch those deprecation warnings were resolved!

@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-not-reviewed labels Mar 5, 2024
@ytmimi ytmimi merged commit 35c1b7d into rust-lang:master Mar 5, 2024
27 checks passed
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants