-
Notifications
You must be signed in to change notification settings - Fork 888
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
StyleEdition
enum and StyleEditionDefault
triat
**Note** This does not add the `style_edition` config option to rustfmt. The `StyleEdition` enum will eventually be used to allow users to configure the `style_edition`, but for now it's added so we can introduce the the `StyleEditionDefault` trait.
- Loading branch information
Showing
3 changed files
with
94 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
use crate::config::StyleEdition; | ||
|
||
/// Defines the default value for the given style edition | ||
pub(crate) trait StyleEditionDefault { | ||
type ConfigType; | ||
fn style_edition_default(style_edition: StyleEdition) -> Self::ConfigType; | ||
} | ||
|
||
/// macro to help implement `StyleEditionDefault` for config options | ||
#[macro_export] | ||
macro_rules! style_edition_default { | ||
($ty:ident, $config_ty:ty, $default:expr) => { | ||
impl crate::config::style_edition::StyleEditionDefault for $ty { | ||
type ConfigType = $config_ty; | ||
|
||
fn style_edition_default(_: crate::config::StyleEdition) -> Self::ConfigType { | ||
$default | ||
} | ||
} | ||
}; | ||
($ty:ident, $config_ty:ty, $default_2015:expr, $default_2024:expr) => { | ||
impl crate::config::style_edition::StyleEditionDefault for $ty { | ||
type ConfigType = $config_ty; | ||
|
||
fn style_edition_default( | ||
style_edition: crate::config::StyleEdition, | ||
) -> Self::ConfigType { | ||
match style_edition { | ||
crate::config::StyleEdition::Edition2015 | ||
| crate::config::StyleEdition::Edition2018 | ||
| crate::config::StyleEdition::Edition2021 => $default_2015, | ||
crate::config::StyleEdition::Edition2024 => $default_2024, | ||
} | ||
} | ||
} | ||
}; | ||
} | ||
|
||
#[cfg(test)] | ||
mod test { | ||
use super::*; | ||
use crate::config::StyleEdition; | ||
|
||
#[test] | ||
fn test_impl_default_style_edition_struct_for_all_editions() { | ||
struct Unit; | ||
style_edition_default!(Unit, usize, 100); | ||
|
||
// regardless of the style edition used the value will always return 100 | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2015), 100); | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2018), 100); | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2021), 100); | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2024), 100); | ||
} | ||
|
||
#[test] | ||
fn test_impl_default_style_edition_for_old_and_new_editions() { | ||
struct Unit; | ||
style_edition_default!(Unit, usize, 100, 50); | ||
|
||
// style edition 2015-2021 are all the same | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2015), 100); | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2018), 100); | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2021), 100); | ||
|
||
// style edition 2014 | ||
assert_eq!(Unit::style_edition_default(StyleEdition::Edition2024), 50); | ||
} | ||
} |