-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "detailed-query.html" column headers #648
Comments
Also maybe the "time" and "total time" columns should be swapped, so that the delta column is always next to the thing it is the delta of? |
Full executions is the number of times the query actually ran vs. the number of times it was invoked (and possibly hit the cache). Loading time is the time it took for us to "deserialize" query results from incremental cache, I think, though possibly also metadata? |
Ah. That's what I would have already expected with "executions".
I see. Maybe "cache fill time" or "deserialize time" would be better. (Currently it is not even clear that the unit is time.) |
Did some work on this in 81f6f7d, which hopefully helps here. Feel free to close (or provide further feedback). |
Actually I'm going to go ahead and close -- please leave a comment/reopen/whatever if you have further feedback. |
Looking at a page like https://perf.rust-lang.org/detailed-query.html?commit=89530668eb34ae5856fd9aabf52a7c8afaa08808&base_commit=43271a39adc26d29350d4830b594c6435472815e&benchmark=script-servo-opt&run_name=incr-patched:%20println, I am quite confused -- it took me a while to figure out what these columns mean.
As a concrete suggestion, I think the three columns titled
Δ
(which looks like an upwards arrow indicating sort order, not an actual title) should get proper titles, like "Time delta", "Full executions delta" and "Loading delta" (assuming that's what they are).Beyond that, "Full executions" and "Loading" are somewhat puzzling concepts. I would understand "executions", that's probably "how often did this thing run", but why "full"? And for "loading" I do not have the slightest clue what that might be.
The text was updated successfully, but these errors were encountered: