Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query verification is a little non-deterministic #1105

Closed
Mark-Simulacrum opened this issue Nov 16, 2021 · 1 comment · Fixed by #1123
Closed

query verification is a little non-deterministic #1105

Mark-Simulacrum opened this issue Nov 16, 2021 · 1 comment · Fixed by #1123

Comments

@Mark-Simulacrum
Copy link
Member

I suspect in part due to Spans having a hash dependent on the commit hash (since we remap paths to include the commit hash), we are seeing increased noise in benchmarks (particularly incr-unchanged) that is not yet being ignored by the statistical significance algorithm as it was fairly recently introduced.

I suspect we'll want to do one of these:

  • Disable the verification entirely under perf.rlo (needs rustc work)
  • Fully enable the verification under perf.rlo (just a flag, but comes at a performance hit)
  • Just accept increased noise levels which should fairly soon be less impactful due to the last 50 commits all being after the noise started in earnest, presuming our algorithm works.
@the8472
Copy link
Member

the8472 commented Nov 19, 2021

Fully enable the verification under perf.rlo (just a flag, but comes at a performance hit)

This seems preferable so we don't miss regressions in the cost of the verification itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants