Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to modify feature gates #968

Merged
merged 3 commits into from
Nov 27, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Nov 23, 2020

How to remove them and how to rename them.

cc rust-lang/rust#79336 (comment)
cc @varkor

How to remove them and how to rename them.

cc <rust-lang/rust#79336 (comment)>
cc @varkor
src/feature-gates.md Outdated Show resolved Hide resolved
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unless you want to wait for varkor to review.

@camelid
Copy link
Member Author

camelid commented Nov 24, 2020

I'm fine either way. Worst comes to worse, we can always update the docs :)

I pushed a new commit at the same time you submitted your review though, so you might want to take another look.

@varkor
Copy link
Member

varkor commented Nov 26, 2020

Looks good to me too 👍

@jyn514 jyn514 merged commit f9b3946 into rust-lang:master Nov 27, 2020
@camelid camelid deleted the feature-gate-modification branch November 27, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants