Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow anyone to change the status of a PR #910

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Allows anyone to change the status of PRs by using the @rustbot modify labels command, so this is allowed now.

@LeSeulArtichaut LeSeulArtichaut added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 4, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 4, 2020

Is there a way to limit this only to the author of the PR? I don't want random people coming along and changing the status.

@LeSeulArtichaut
Copy link
Contributor Author

Pretty sure that's not possible, but the same thing is allowed on rust-lang/rust and I have never seen any problem (and I think doing that there would bring much more chaos!)

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I definitely want people to be able to add 'waiting-on-review'.

@jyn514 jyn514 merged commit 5ee77ba into rust-lang:master Oct 4, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the relabel-pr-status branch October 4, 2020 14:28
@LeSeulArtichaut
Copy link
Contributor Author

@jyn514 Should we also add an "auto-labeler" to add waiting-on-review to all PRs when opened?

@jyn514
Copy link
Member

jyn514 commented Oct 4, 2020

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants