Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustc_mir related links #1228

Merged
merged 18 commits into from
Oct 28, 2021
Merged

Fix rustc_mir related links #1228

merged 18 commits into from
Oct 28, 2021

Conversation

Lee-Janggun
Copy link
Contributor

@Lee-Janggun Lee-Janggun commented Oct 9, 2021 •
edited
Loading

  • With Split rustc_mir rust#80522, rustc_mir has been split into 5 crates, effectively invalidating all related links
  • This PR fixes such links, with a few issues.

The "main" MIR page

NoLandingPads

Hardcoded Versions

  • In src/sanitizers.md, there are a few hardcoded links to docs version 1.55.0 that point to the rustc_mir crate. I wasn't sure how to change this so I left it as is.

@camelid camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 12, 2021
@camelid camelid linked an issue Oct 12, 2021 that may be closed by this pull request
Update links to rustc_mir to use the new names #1225
Closed
@JohnTitor JohnTitor self-requested a review October 17, 2021 17:18
@nhamovitz
Update function name
1746afe 
I'm not sure, but I think the name of the function must have been changed during the move. The link as it was went to the `InterpCx` struct but didn't jump down to the function
@nhamovitz
Copy link
Contributor

Opened #2 on @Lee-Janggun's branch — one of the functions was also renamed during the move, so the jump-to-function with the html id wasn't working

JohnTitor
JohnTitor reviewed Oct 20, 2021
View reviewed changes
src/borrow_check.md Outdated Show resolved Hide resolved
src/mir/optimizations.md Outdated Show resolved Hide resolved
src/mir/passes.md Outdated Show resolved Hide resolved
@JohnTitor
Copy link
Member

Lee-Janggun and others added 2 commits October 20, 2021 17:33
@Lee-Janggun
Copy link
Contributor Author

I'll work on the rest near the weekend. Is it possible for me to change the tag?

@JohnTitor
Copy link
Member

You could do via a comment: @rustbot label: -waiting-on-review +waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Oct 21, 2021
@Lee-Janggun
Copy link
Contributor Author

I applied the comments, and also added comments to where NoLandingPads were mentioned for future reference.

@rustbot label: +waiting-on-review -waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Oct 27, 2021
JohnTitor
JohnTitor reviewed Oct 28, 2021
View reviewed changes
src/mir/index.md Outdated Show resolved Hide resolved
src/mir/index.md Outdated Show resolved Hide resolved
JohnTitor
JohnTitor approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, applied some minor fixes via 184d33c. Thanks for working on it!

@JohnTitor JohnTitor merged commit ddaebd8 into rust-lang:master Oct 28, 2021
@ehuss ehuss mentioned this pull request Nov 10, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 10, 2021
@matthiaskrgr
Rollup merge of rust-lang#90751 - ehuss:update-books, r=ehuss
a2a4f5e 
Update books

## nomicon

1 commits in 358e6a61d5f4f0496d0a81e70cdcd25d05307342..c6b4bf831e9a40aec34f53067d20634839a6778b
2021-10-20 11:23:12 -0700 to 2021-11-09 02:30:56 +0900
- Replace some use of variant with covariant (rust-lang/nomicon#322)

## book

11 commits in fd9299792852c9a368cb236748781852f75cdac6..5c5dbc5b196c9564422b3193264f3288d2a051ce
2021-10-22 21:59:46 -0400 to 2021-11-09 19:30:43 -0500
- Fix constants link.
- Fix updated anchor
- Propagate edits to chapter 2 back
- Edits to nostarch's chapter 3 edits
- ch 3 from nostarch
- Fix Cargo.toml snippet about custom derive macros
- Snapshot of chapter 9 for nostarch
- Create tmp/src for converting quotes, not sure why this broke but ok
- Update question mark to better explain where it can be used
- Clarify sentence about Results in functions that don't return Result. Fixes rust-lang/book#2912.
- Merge pull request rust-lang/book#2913 from covariant/patch-1

## rust-by-example

2 commits in 27f1ff5e440ef78828b68ab882b98e1b10d9af32..e9d45342d7a6c1def4731f1782d87ea317ba30c3
2021-10-13 08:04:40 -0300 to 2021-11-02 13:33:03 -0500
- Enums: Linked-List Needs Re-Wording (rust-lang/rust-by-example#1469)
- fix: Use the point as top left corner for `square` (rust-lang/rust-by-example#1471)

## rustc-dev-guide

13 commits in b06008731af0f7d07cd0614e820c8276dfed1c18..196ef69aa68f2cef44f37566ee7db37daf00301b
2021-10-21 15:13:09 -0500 to 2021-11-07 07:48:47 -0600
- Fix typo: [upv.rs_mentioned] -> [upvars_mentioned]
- Add note to emphasize replacing TARGET_TRIPLE (rust-lang/rustc-dev-guide#1250)
- Remove some legacy test suites.
- tiny capitalization fix
- Fix date
- Update some date-check comments
- Ensure date-check cron job is using latest stable Rust
- enhance subtree docs, link to clippy docs
- Edit introduction to bootstrapping
- Some minor adjustments to the diagnostic documentation
- Edit "About this guide" for semantic line feeds
- Fix `rustc_mir` related links (rust-lang/rustc-dev-guide#1228)
- Add documentation for LLVM CFI support

## edition-guide

3 commits in 7c0088ca744d293a5f4b1e2ac378e7c23d30fe55..27f4a84d3852e9416cae5861254fa53a825c56bd
2021-10-05 13:28:05 +0200 to 2021-11-08 10:13:20 -0500
- Add a missing period (rust-lang/edition-guide#271)
- Fix syntax error in code example (rust-lang/edition-guide#270)
- Fixed an example error of prelude.md (rust-lang/edition-guide#269)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 10, 2021
@matthiaskrgr
Rollup merge of rust-lang#90751 - ehuss:update-books, r=ehuss
e737501 
Update books

## nomicon

1 commits in 358e6a61d5f4f0496d0a81e70cdcd25d05307342..c6b4bf831e9a40aec34f53067d20634839a6778b
2021-10-20 11:23:12 -0700 to 2021-11-09 02:30:56 +0900
- Replace some use of variant with covariant (rust-lang/nomicon#322)

## book

11 commits in fd9299792852c9a368cb236748781852f75cdac6..5c5dbc5b196c9564422b3193264f3288d2a051ce
2021-10-22 21:59:46 -0400 to 2021-11-09 19:30:43 -0500
- Fix constants link.
- Fix updated anchor
- Propagate edits to chapter 2 back
- Edits to nostarch's chapter 3 edits
- ch 3 from nostarch
- Fix Cargo.toml snippet about custom derive macros
- Snapshot of chapter 9 for nostarch
- Create tmp/src for converting quotes, not sure why this broke but ok
- Update question mark to better explain where it can be used
- Clarify sentence about Results in functions that don't return Result. Fixes rust-lang/book#2912.
- Merge pull request rust-lang/book#2913 from covariant/patch-1

## rust-by-example

2 commits in 27f1ff5e440ef78828b68ab882b98e1b10d9af32..e9d45342d7a6c1def4731f1782d87ea317ba30c3
2021-10-13 08:04:40 -0300 to 2021-11-02 13:33:03 -0500
- Enums: Linked-List Needs Re-Wording (rust-lang/rust-by-example#1469)
- fix: Use the point as top left corner for `square` (rust-lang/rust-by-example#1471)

## rustc-dev-guide

13 commits in b06008731af0f7d07cd0614e820c8276dfed1c18..196ef69aa68f2cef44f37566ee7db37daf00301b
2021-10-21 15:13:09 -0500 to 2021-11-07 07:48:47 -0600
- Fix typo: [upv.rs_mentioned] -> [upvars_mentioned]
- Add note to emphasize replacing TARGET_TRIPLE (rust-lang/rustc-dev-guide#1250)
- Remove some legacy test suites.
- tiny capitalization fix
- Fix date
- Update some date-check comments
- Ensure date-check cron job is using latest stable Rust
- enhance subtree docs, link to clippy docs
- Edit introduction to bootstrapping
- Some minor adjustments to the diagnostic documentation
- Edit "About this guide" for semantic line feeds
- Fix `rustc_mir` related links (rust-lang/rustc-dev-guide#1228)
- Add documentation for LLVM CFI support

## edition-guide

3 commits in 7c0088ca744d293a5f4b1e2ac378e7c23d30fe55..27f4a84d3852e9416cae5861254fa53a825c56bd
2021-10-05 13:28:05 +0200 to 2021-11-08 10:13:20 -0500
- Add a missing period (rust-lang/edition-guide#271)
- Fix syntax error in code example (rust-lang/edition-guide#270)
- Fixed an example error of prelude.md (rust-lang/edition-guide#269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update links to rustc_mir to use the new names
5 participants
@Lee-Janggun @nhamovitz @JohnTitor @camelid @rustbot