Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document HIR ty lowering #178

Open
4 tasks
nikomatsakis opened this issue Aug 8, 2018 · 10 comments
Open
4 tasks

Document HIR ty lowering #178

nikomatsakis opened this issue Aug 8, 2018 · 10 comments
Assignees
@fmease
Labels
A-HIR Area: high-level intermediate representation (HIR) C-enhancement Category: enhancement E-hard Difficulty: might require advanced knowledge E-help-wanted Call for participation: extra help is wanted T-compiler Relevant to compiler team T-types Relevant to types team

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 8, 2018 •
edited by fmease
Loading

Note

The issue description has been rewritten by @fmease.

See its API docs: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/hir_ty_lowering/index.html.

The chapter should explain:

  • Meaning & origin of its current name (HIR ty lowering) and of its previous name (astconv).
  • Purpose, incl. bigger picture
  • "Conventions", "restrictions", "self imposed rules" (e.g., Various HirTyLowerer cleanups rust#125819 (comment)).
  • "Limitations" (cc arbitrary shorthand projection & inherent associated type debates)
@mark-i-m mark-i-m added the E-help-wanted Call for participation: extra help is wanted label Aug 11, 2018
@rajcspsg

This comment has been minimized.

Sign in to view
@mark-i-m

This comment has been minimized.

Sign in to view
@rajcspsg

This comment has been minimized.

Sign in to view
@mark-i-m

This comment has been minimized.

Sign in to view
@mark-i-m mark-i-m added the E-hard Difficulty: might require advanced knowledge label Jan 18, 2019
@nikomatsakis

This comment has been minimized.

Sign in to view
@nikomatsakis

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added C-enhancement Category: enhancement A-HIR Area: high-level intermediate representation (HIR) T-compiler Relevant to compiler team A-AST Area: abstract syntax tree labels Nov 4, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 4, 2024

Triage: astconv isn't a thing anymore AFAIK, it's probably now called ast_lowering.

@fmease
Copy link
Member

fmease commented Nov 4, 2024

Nope, it's called HIR ty lowering

@fmease fmease changed the title document astconv Document HIR ty lowering Nov 4, 2024
@fmease fmease added T-types Relevant to types team and removed A-AST Area: abstract syntax tree labels Nov 4, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 4, 2024

(For easier reference, the PR that renamed it is rust-lang/rust#120926)

@fmease fmease self-assigned this Nov 4, 2024
@fmease
Copy link
Member

fmease commented Nov 4, 2024 •
edited
Loading

Tentatively assigning myself but I invite others to contribute too if I take too long (cuz I prolly won't prioritize this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmease fmease

Labels
A-HIR Area: high-level intermediate representation (HIR) C-enhancement Category: enhancement E-hard Difficulty: might require advanced knowledge E-help-wanted Call for participation: extra help is wanted T-compiler Relevant to compiler team T-types Relevant to types team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nikomatsakis @mark-i-m @rajcspsg @fmease @jieyouxu