Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split create_def and lowering of lifetimes for opaque types and bare async fns #99867

Merged
merged 56 commits into from
Aug 5, 2022
Merged

Split create_def and lowering of lifetimes for opaque types and bare async fns #99867

merged 56 commits into from
Aug 5, 2022

Commits on Aug 4, 2022

  1. Remove old docs on lower_async_fn_ret_ty

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    5c23a2e View commit details
    Browse the repository at this point in the history

  2. Make lower_generic_bound_predicate receive AST bounds instead of HIR … 

    …bounds
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    b14c957 View commit details
    Browse the repository at this point in the history

  3. Add captures flag to capture or not while lowering

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    0f11a0c View commit details
    Browse the repository at this point in the history

  4. Unroll while_capturing_lifetimes into lower_opaque_impl_trait

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    84a24a1 View commit details
    Browse the repository at this point in the history

  5. Explicitly gather lifetimes and definitions in RPIT

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    cda2c04 View commit details
    Browse the repository at this point in the history

  6. Add debug! calls

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    399609e View commit details
    Browse the repository at this point in the history

  7. Remove NEW_COLLECT_LIFETIMES env var

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    fac7631 View commit details
    Browse the repository at this point in the history

  8. Extract create_and_capture_lifetime_defs function

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    25825cd View commit details
    Browse the repository at this point in the history

  9. Explicitly gather lifetimes and definitions for bare async fns

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    19dcbd1 View commit details
    Browse the repository at this point in the history

  10. There's no need to check binders_to_ignore using the old code anymore

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    5a184ac View commit details
    Browse the repository at this point in the history

  11. Do not execute captures code for async fns

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9c0d9ba View commit details
    Browse the repository at this point in the history

  12. Do not execute captures code when lowering lifetimes as GenericArg

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    20c88a2 View commit details
    Browse the repository at this point in the history

  13. Completely remove captures flag

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9f77688 View commit details
    Browse the repository at this point in the history

  14. Move LifetimeCollectVisitor to rustc_ast_lowering

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    4f334f2 View commit details
    Browse the repository at this point in the history

  15. Skip lifetimes in binders when visiting

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    05b989e View commit details
    Browse the repository at this point in the history

  16. Restructure visit_ty in a more clear way

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    81c4d23 View commit details
    Browse the repository at this point in the history

  17. Record RPITs elided lifetimes in path segments

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    1802d45 View commit details
    Browse the repository at this point in the history

  18. Record RPITs elided lifetimes in Rptr Tys

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    c390bda View commit details
    Browse the repository at this point in the history

  19. Fail if LifetimeRes is Infer when creating def ids for lifetimes copies

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    14ea178 View commit details
    Browse the repository at this point in the history

  20. new_named_lifetime_with_res's LifetimeRes::Param should have created … 

    …def_id already
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    3030ab3 View commit details
    Browse the repository at this point in the history

  21. new_named_lifetime_with_res's LifetimeRes::Fresh should have created … 

    …def_id already
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    d9e6364 View commit details
    Browse the repository at this point in the history

  22. No need to check binders to ignore on new_named_lifetime_with_res's L… 

    …ifetimeRes::Param
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    6041ed0 View commit details
    Browse the repository at this point in the history

  23. No need to check binders to ignore on new_named_lifetime_with_res's L… 

    …ifetimeRes::Fresh
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    552f6b0 View commit details
    Browse the repository at this point in the history

  24. No need to store parent_def_id in LifetimeCaptureContext

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    95158fd View commit details
    Browse the repository at this point in the history

  25. Remove binders_to_ignore from LifetimeCaptureContext

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    6c6a81e View commit details
    Browse the repository at this point in the history

  26. Create new_mapping local structure and avoid checking def_ids on capt… 

    …ures
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    f6b4dd1 View commit details
    Browse the repository at this point in the history

  27. Capture things as Lifetime object to simplify things

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    2d826e2 View commit details
    Browse the repository at this point in the history

  28. Remove local_def_id from captured_lifetimes

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    f0db1d6 View commit details
    Browse the repository at this point in the history

  29. Implement def_id based remapping

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    1d6cebf View commit details
    Browse the repository at this point in the history

  30. Remove captured_lifetimes and LifetimeCaptureContext and make create_… 

    …lifetime_defs return the captures
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    1380062 View commit details
    Browse the repository at this point in the history

  31. create_and_capture_lifetime_defs -> create_lifetime_defs

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    cd3c388 View commit details
    Browse the repository at this point in the history

  32. Avoid explicitly handling res when is not needed

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    40bcbed View commit details
    Browse the repository at this point in the history

  33. Add comments about lifetime collect and create lifetime defs for RPITs

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    7858509 View commit details
    Browse the repository at this point in the history

  34. Document generics_def_id_map field and record/get methods on it

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    966269a View commit details
    Browse the repository at this point in the history

  35. Document opt_local_def_id

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    c946cdc View commit details
    Browse the repository at this point in the history

  36. Add comments on with_remapping

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    11e00f5 View commit details
    Browse the repository at this point in the history

  37. with_lifetime_binder is now lower_lifetime_binder and doesn't need a … 

    …closure
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    6289d0e View commit details
    Browse the repository at this point in the history

  38. Document lower_opaque_impl_trait

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    d85720a View commit details
    Browse the repository at this point in the history

  39. Document what collected_lifetimes vec containts

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    76b518f View commit details
    Browse the repository at this point in the history

  40. Move lifetimes_in_bounds call to outside with_hir_id_owner block in l… 

    …ower_opaque_impl_trait
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    4b9b583 View commit details
    Browse the repository at this point in the history

  41. Move lifetimes_in_bounds call to outside with_hir_id_owner block in l… 

    …ower_async_fn_ret_ty
    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    12fa339 View commit details
    Browse the repository at this point in the history

  42. captures -> collected_lifetimes

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    3f7db37 View commit details
    Browse the repository at this point in the history

  43. Move hir_bounds after lifetime_defs

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9c7de6f View commit details
    Browse the repository at this point in the history

  44. Add documentation about lifetime_defs

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    a3bfdc7 View commit details
    Browse the repository at this point in the history

  45. Add documentation about lifetime args

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    cab6740 View commit details
    Browse the repository at this point in the history

  46. Add more debug calls

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    2f353d1 View commit details
    Browse the repository at this point in the history

  47. Add documentation for create_lifetime_defs

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    1ece866 View commit details
    Browse the repository at this point in the history

  48. Move new_remapping inside with_hir_id_owner

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9f10f58 View commit details
    Browse the repository at this point in the history

  49. Extract record_elided_anchor

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    f8b1b2b View commit details
    Browse the repository at this point in the history

  50. Add docs to record_elided_anchor

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    5e71659 View commit details
    Browse the repository at this point in the history

  51. Add docs to generics_def_id_map

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    c0923c8 View commit details
    Browse the repository at this point in the history

  52. Use span_bug instead of panic

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    45991f9 View commit details
    Browse the repository at this point in the history

  53. Do not collect lifetimes with Infer resolution

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    ece5245 View commit details
    Browse the repository at this point in the history

  54. Improve record_def_id_remap docs

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    bf1c7da View commit details
    Browse the repository at this point in the history

  55. Improve opt_local_def_id docs

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    065e497 View commit details
    Browse the repository at this point in the history

  56. Fix typo

    @spastorino
    spastorino committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    4170d73 View commit details
    Browse the repository at this point in the history