Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #99849

Merged
merged 13 commits into from
Jul 28, 2022
Merged

Rollup of 5 pull requests #99849

merged 13 commits into from
Jul 28, 2022

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ouz-a and others added 13 commits July 25, 2022 15:45
@ouz-a
Bubble up obligations
4a0473c
@ouz-a
add tests and comment
8716eae
@GuillaumeGomez
Fix settings display on small screen size
9d118c5
@GuillaumeGomez
Add GUI test for settings in small device
1564305
@bstrie
Allow using stable os::fd::raw items through unstable os::wasi module
0eb28ab 
This fixes a regression from stable to nightly.

Closes rust-lang#99502.
@TaKO8Ki
avoid Symbol to String conversions
3cbc944
@TaKO8Ki
change the type of note field to Option<String>
089471b
@TaKO8Ki
remove an unnecessary line break
2ce42eb
@Dylan-DPC
Rollup merge of rust-lang#99714 - ouz-a:issue_57961, r=oli-obk
91b8b9b 
Fix regression introduced with rust-lang#99383

Fixes rust-lang#99642
@Dylan-DPC
Rollup merge of rust-lang#99723 - bstrie:wasifd, r=yaahc
f326692 
Allow using stable os::fd::raw items through unstable os::wasi module

This fixes a regression from stable to nightly.

Closes rust-lang#99502.
@Dylan-DPC
Rollup merge of rust-lang#99810 - GuillaumeGomez:fix-settings-slider-…
3c4a66d 
…small-width, r=notriddle

Fix settings slider on small width screens

Fixes rust-lang#99794.

Screenshot of the fix:

![Screenshot from 2022-07-27 14-17-08](https://user-images.githubusercontent.com/3050060/181250007-55f982d1-89db-45b7-a4f1-0d1729e6a3e3.png)

cc `````@jsha`````
r? `````@notriddle`````
@Dylan-DPC
Rollup merge of rust-lang#99837 - TaKO8Ki:avoid-symbol-to-string-conv…
3a37c9a 
…ersions, r=fee1-dead

Avoid `Symbol` to `String` conversions

follow-up to rust-lang#99508
@Dylan-DPC
Rollup merge of rust-lang#99846 - TaKO8Ki:refactor-UnresolvedImportEr…
71b0e95 
…ror, r=davidtwco

Refactor `UnresolvedImportError`

This patch changes the type of `note` field in `UnresolvedImportError` to `Option<String>`.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 28, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Jul 28, 2022

📌 Commit 71b0e95 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 28, 2022
@bors
Copy link
Contributor

bors commented Jul 28, 2022

⌛ Testing commit 71b0e95 with merge e568261...

@bors
Copy link
Contributor

bors commented Jul 28, 2022

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing e568261 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2022
@bors bors merged commit e568261 into rust-lang:master Jul 28, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 28, 2022
@bors bors mentioned this pull request Jul 28, 2022
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e568261): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 2.8% 2.8% 1
Regressions 😿
(secondary)		 3.9% 4.9% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.2% -2.2% 1
All 😿🎉 (primary) 2.8% 2.8% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.0% -2.0% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.0% -2.0% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Dylan-DPC @bors @rust-timer @rustbot @ouz-a @GuillaumeGomez @bstrie @TaKO8Ki