Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak SubstFolder implementation #99600

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Tweak SubstFolder implementation #99600

merged 4 commits into from
Jul 25, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jul 22, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 22, 2022
@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2022
@tmiasko
Copy link
Contributor Author

tmiasko commented Jul 22, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2022
@bors
Copy link
Contributor

bors commented Jul 22, 2022

⌛ Trying commit 33f85f96a8d0019428bacb82c60544b45576f7e0 with merge 014f8963d55c62c9ab3088f4dfebf2d010b8c310...

@bors
Copy link
Contributor

bors commented Jul 22, 2022

☀️ Try build successful - checks-actions
Build commit: 014f8963d55c62c9ab3088f4dfebf2d010b8c310 (014f8963d55c62c9ab3088f4dfebf2d010b8c310)

@rust-timer
Copy link
Collaborator

Queued 014f8963d55c62c9ab3088f4dfebf2d010b8c310 with parent 41419e7, future comparison URL.

@tmiasko
Inline DebruijnIndex methods
bb73f17
@tmiasko
Inline Predicate::has_vars_bound_at_or_above
0e6251d
@tmiasko
Inline SubstFolder::tcx
880bde0
@tmiasko
Outline SubstFolder bug reporting code paths
e497fb1 
Bug reporting macro `span_bug!` generates quite a bit of code,
we don't expect to execute. Outline it into a separate function.
@tmiasko
Copy link
Contributor Author

tmiasko commented Jul 22, 2022

@bors try

@bors
Copy link
Contributor

bors commented Jul 22, 2022

⌛ Trying commit e497fb1 with merge a4e2471b02d6ee792029881218204c4f6ef4e1d4...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (014f8963d55c62c9ab3088f4dfebf2d010b8c310): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 0.9% 1.1% 6
Improvements 🎉
(primary)		 -0.6% -0.9% 9
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -0.6% -0.9% 9

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.5% 2.5% 1
Improvements 🎉
(primary)		 -2.6% -2.6% 1
Improvements 🎉
(secondary)		 -2.6% -2.6% 1
All 😿🎉 (primary) -2.6% -2.6% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.4% 2.4% 1
Improvements 🎉
(primary)		 -3.8% -6.8% 3
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -3.8% -6.8% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2022
@bors
Copy link
Contributor

bors commented Jul 22, 2022

☀️ Try build successful - checks-actions
Build commit: a4e2471b02d6ee792029881218204c4f6ef4e1d4 (a4e2471b02d6ee792029881218204c4f6ef4e1d4)

@tmiasko
Copy link
Contributor Author

tmiasko commented Jul 22, 2022

@rust-timer build a4e2471b02d6ee792029881218204c4f6ef4e1d4

@rust-timer
Copy link
Collaborator

Queued a4e2471b02d6ee792029881218204c4f6ef4e1d4 with parent 41419e7, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a4e2471b02d6ee792029881218204c4f6ef4e1d4): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.6% -0.9% 10
Improvements 🎉
(secondary)		 -2.5% -3.3% 6
All 😿🎉 (primary) -0.6% -0.9% 10

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -3.2% -6.4% 4
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -3.2% -6.4% 4

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 24, 2022

📌 Commit e497fb1 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2022
@bors
Copy link
Contributor

bors commented Jul 25, 2022

⌛ Testing commit e497fb1 with merge 2f320a2...

@bors
Copy link
Contributor

bors commented Jul 25, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 2f320a2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2022
@bors bors merged commit 2f320a2 into rust-lang:master Jul 25, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 25, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2f320a2): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.6% 1.6% 1
Improvements 🎉
(primary)		 -0.4% -0.6% 22
Improvements 🎉
(secondary)		 -1.6% -3.6% 14
All 😿🎉 (primary) -0.4% -0.6% 22

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.6% 2.6% 1
Improvements 🎉
(primary)		 -2.7% -2.7% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.7% -2.7% 1

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@tmiasko tmiasko deleted the subst-folder branch July 25, 2022 12:17
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 28, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tmiasko @rust-highfive @rust-timer @bors @petrochenkov @rustbot