Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for Rust 1.63.0 #99524

Merged
merged 7 commits into from
Aug 6, 2022
Merged

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 20, 2022

No description provided.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2022
@cuviper
Copy link
Member Author

cuviper commented Jul 20, 2022

This should be good as far as capturing noteworthy items, but suggestions are welcome in case I missed anything, especially for interesting "internal changes". I still need to tweak a lot of the wording and link stabilized APIs too.

cc @rust-lang/release

@slanterns

This comment was marked as resolved.

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
@joshtriplett
Copy link
Member

joshtriplett commented Jul 21, 2022

I think the likely highlights for a blog post would be:

  • I/O Safety, with a detailed explanation and some guidance about using it (e.g. using this instead of RawFd in libraries).
  • explicit_generic_args_with_impl_trait (as a paragraph-sized note with one code example)
  • The removal of migration mode in the borrow checker (as a brief mention with a link to the post at add nll-by-default blog post blog.rust-lang.org#989 , which we should merge before the release).

@cuviper cuviper marked this pull request as ready for review August 4, 2022 18:48
RELEASES.md Show resolved Hide resolved
Copy link
Contributor

@tspiteri tspiteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested [] break links.

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
cuviper and others added 2 commits August 5, 2022 10:02
Co-authored-by: Trevor Spiteri <[email protected]>
Co-authored-by: Trevor Spiteri <[email protected]>
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup p=1

@bors
Copy link
Contributor

bors commented Aug 6, 2022

📌 Commit 99793d9 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2022
@bors
Copy link
Contributor

bors commented Aug 6, 2022

⌛ Testing commit 99793d9 with merge 44bd81d...

@bors
Copy link
Contributor

bors commented Aug 6, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 44bd81d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2022
@bors bors merged commit 44bd81d into rust-lang:master Aug 6, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 6, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (44bd81d): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
1.3% 1.4% 6
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
1.2% 1.2% 1
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.4% -2.4% 1
All 😿🎉 (primary) 1.2% 1.2% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
3.5% 3.5% 1
Improvements 🎉
(primary)
-3.4% -3.4% 1
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -3.4% -3.4% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@cuviper cuviper deleted the relnotes-1.63.0 branch October 15, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.