Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize NonZero* checked operations constness. #97908

Merged
merged 3 commits into from
Jun 26, 2022
Merged

Stabilize NonZero* checked operations constness. #97908

merged 3 commits into from
Jun 26, 2022

Conversation

iago-lito
Copy link
Contributor

Partial stabilization for #97547 (continued).

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 9, 2022
@rust-highfive
Copy link
Collaborator

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2022
@iago-lito iago-lito mentioned this pull request Jun 9, 2022
Merged
3 tasks
@scottmcm
Copy link
Member

With the FCP done (#97547 (comment)), this looks good to me.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 26, 2022

📌 Commit 2339bb2 has been approved by scottmcm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#97908 - iago-lito:stabilize_nonzero_checked…
a9a2d60 
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 26, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#97908 - iago-lito:stabilize_nonzero_checked…
ce5ea90 
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 26, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2022
@matthiaskrgr
Rollup merge of rust-lang#97908 - iago-lito:stabilize_nonzero_checked…
f8e3771 
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 26, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 26, 2022
@matthiaskrgr
Rollup merge of rust-lang#97908 - iago-lito:stabilize_nonzero_checked…
96e9d84 
…_ops_constness, r=scottmcm

Stabilize NonZero* checked operations constness.

Partial stabilization for rust-lang#97547 (continued).
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 26, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 26, 2022
@bors
Auto merge of rust-lang#98545 - matthiaskrgr:rollup-njely29, r=matthi…
c80c4b8 
…askrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#97140 (std: use an event-flag-based thread parker on SOLID)
 - rust-lang#97295 ([rustc_parse] Forbid `let`s in certain places)
 - rust-lang#97743 (make const_err show up in future breakage reports)
 - rust-lang#97908 (Stabilize NonZero* checked operations constness.)
 - rust-lang#98297 (Transform help popup into a pocket menu)
 - rust-lang#98428 (macros: use typed identifiers in diag and subdiag derive)
 - rust-lang#98528 (Respect --color when building rustbuild itself)
 - rust-lang#98535 (Add regression test for generic const in rustdoc)
 - rust-lang#98538 (Add a ui test for issue rust-lang#91883)
 - rust-lang#98540 (Add regression test for rust-lang#87558)
 - rust-lang#98541 (Update `std::alloc::System` doc example code style)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e8a2e26 into rust-lang:master Jun 26, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
5 participants
@iago-lito @rust-highfive @scottmcm @bors @rustbot