Move download-rustc from python to rustbuild #96687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
15 tasks
jyn514
force-pushed
the
download-rustc
branch
2 times, most recently
from
03f0a9a to
3dc6364
Compare
bjorn3
reviewed
May 4, 2022
bjorn3
reviewed
May 4, 2022
|
r=me with nits fixed |
|
@Mark-Simulacrum this is ready for review :) |
|
☔ The latest upstream changes (presumably #96602) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark-Simulacrum
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
apiraino
added
the
T-infra
This has no logic changes, just a move.
- Remove download-rustc handling from bootstrap.py - Allow a custom `pattern` in `builder.unpack()` - Only download rustc once another part of bootstrap depends on it. This is somewhat necessary since the download functions rely on having a full `Builder`, which isn't available until after config parsing finishes.
This is for a pre-existing FIXME, but it was easy enough to do.
|
@bors r+ rollup=iffy |
|
📌 Commit 00bb4df has been approved by |
bors
added
S-waiting-on-bors
This was referenced May 29, 2022
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (303d916): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 8, 2022
…ulacrum Move rustfmt downloads from bootstrap.py to rustbuild - Allow verifying CI downloads using src/stage0.json - Change download functions not to hard-code `ci-artifacts.rust-lang.org` - Change `format::format` to take a `Builder` so it has access to `download_component`. I think we may want to reconsider the distinction between Build and Builder at some point; I don't think it's particularly useful. - Move rustfmt downloads out of bootstrap.py Fixes rust-lang#95136. Helps with rust-lang#94829. This is based on rust-lang#96687 for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove download-rustc handling from bootstrap.py
Allow a custom
patterninbuilder.unpack()Only download rustc once another part of bootstrap depends on it.
This is somewhat necessary since the download functions rely on having a full
Builder, which isn't available until after config parsing finishes.Helps with #94829.