Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all hir::Map methods consistently by-value #93853

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Make all hir::Map methods consistently by-value #93853

merged 2 commits into from
Feb 11, 2022

Conversation

steffahn
Copy link
Member

@steffahn steffahn commented Feb 10, 2022 •
edited
Loading

hir::Map only consists of a single reference (as part of the contained TyCtxt) anyways, so copying is literally zero overhead compared to passing a reference

@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 10, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2022
@steffahn
Make all hir::Map methods consistently by-value
89ac81a 
(hir::Map only consists of a single reference anyways)
@steffahn
Copy link
Member Author

steffahn commented Feb 10, 2022 •
edited
Loading

(Also contains a change from using unreachable to simply touching the !, in a related impl)

@Aaron1011
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 10, 2022
@bors
Copy link
Contributor

bors commented Feb 10, 2022

⌛ Trying commit 7eff2fe with merge 6488fa74e03fda1b97136a83ee94ad2848a6eb5b...

@bors
Copy link
Contributor

bors commented Feb 10, 2022

☀️ Try build successful - checks-actions
Build commit: 6488fa74e03fda1b97136a83ee94ad2848a6eb5b (6488fa74e03fda1b97136a83ee94ad2848a6eb5b)

@rust-timer
Copy link
Collaborator

Queued 6488fa74e03fda1b97136a83ee94ad2848a6eb5b with parent 56cd04a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6488fa74e03fda1b97136a83ee94ad2848a6eb5b): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 10, 2022
@wesleywiser
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 10, 2022

@wesleywiser: 🔑 Insufficient privileges: Not in reviewers

@wesleywiser
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 10, 2022

📌 Commit 7eff2fe has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2022
@Aaron1011
Copy link
Member

@bors rollup

@Aaron1011
Copy link
Member

@bors rollup=maybe

@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2022
@bors
Auto merge of rust-lang#93891 - matthiaskrgr:rollup-xadut8w, r=matthi…
78450d2 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#92242 (Erase regions before calculating layout for packed field capture)
 - rust-lang#93443 (Add comment on stable_hash_impl for OwnerNodes)
 - rust-lang#93742 (Drop rustc-docs from complete profile)
 - rust-lang#93852 (rustdoc: remove support for multi-query search)
 - rust-lang#93853 (Make all `hir::Map` methods consistently by-value)
 - rust-lang#93861 (Fix ICE if no trait assoc const eq)
 - rust-lang#93862 (Split x86_64-apple builder into two)
 - rust-lang#93864 (Remove ArchiveBuilder::update_symbols)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ddba967 into rust-lang:master Feb 11, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 11, 2022
@steffahn steffahn deleted the map_by_value branch February 11, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
7 participants
@steffahn @rust-highfive @Aaron1011 @rust-timer @bors @wesleywiser @rustbot