Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: dist: defer PlainSourceTarball #93047

Merged
merged 1 commit into from
Jan 23, 2022

Commits on Jan 19, 2022

  1. build: dist: defer PlainSourceTarball

    Apparently it changes some tool sources and invalidates their fingerprints, forcing us to build them several times (before and after vendoring sources).
    I have not dug into why vendoring actually invalidates the figreprints, but the moving the vendoring lower in the pipeline seems to avoid the issue.
    I could imagine that we somehow write a .cargo/config somewhere which somehow makes subsequent builds use the vendored deps but I was not able to find anything.
    
    I checked the sizes of generated archives pre and post patch and their are the same, so I hope there is not functional change.
    
    Fixes rust-lang#93033
    matthiaskrgr committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    5f58a78 View commit details
    Browse the repository at this point in the history