Don't treat unnormalized function arguments as well-formed #91243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Comment on lines
-8
to
-28
| trait MyTrait { | ||
| type Assoc<'a, 'b> where 'b: 'a; | ||
| fn do_sth(arg: Self::Assoc<'_, '_>); | ||
| } | ||
|
|
||
| struct A; | ||
| struct B; | ||
| struct C; | ||
|
|
||
| impl MyTrait for A { | ||
| type Assoc<'a, 'b> where 'b: 'a = u32; | ||
| fn do_sth(_: u32) {} | ||
| } | ||
| impl MyTrait for B { | ||
| type Assoc<'a, 'b> where 'b: 'a = u32; | ||
| fn do_sth(_: Self::Assoc<'_, '_>) {} | ||
| } | ||
| impl MyTrait for C { | ||
| type Assoc<'a, 'b> where 'b: 'a = u32; | ||
| fn do_sth(_: Self::Assoc<'static, 'static>) {} | ||
| } |
There was a problem hiding this comment.
Does this means that #87748 ought to be opened again? Would there be a way to conciliate that issue with the soundness issue fix?
There was a problem hiding this comment.
Yes, it should be. In theory, there are better fixes (that will happen eventually), but a revert is better for now, due to the rather large soundness hole.
|
@bors r+ |
|
📌 Commit eeaa215 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added
the
beta-accepted
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 29, 2021
Don't treat unnormalized function arguments as well-formed Partial revert of rust-lang#88312 r? `@pnkfelix` cc `@nikomatsakis`
|
@bors r=nikomatsakis |
|
📌 Commit 692e96c has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2021
…ulacrum [beta] branch master to beta Bumps channel and includes a backport of: * Don't treat unnormalized function arguments as well-formed rust-lang#91243 r? `@Mark-Simulacrum`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 30, 2021
Don't treat unnormalized function arguments as well-formed Partial revert of rust-lang#88312 r? `@pnkfelix` cc `@nikomatsakis`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#91243 (Don't treat unnormalized function arguments as well-formed) - rust-lang#91250 (Refactor EmitterWriter::emit_suggestion_default ) - rust-lang#91317 (tests: Ignore `test/debuginfo/rc_arc.rs` on windows-gnu) - rust-lang#91323 (CTFE: support assert_zero_valid and assert_uninit_valid) - rust-lang#91358 (Fix small typo) - rust-lang#91360 (:arrow_up: rust-analyzer) - rust-lang#91368 (Don't re-export `MirPass`) - rust-lang#91383 (Add `drop_while` as doc alias to `Iterator::skip_while`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 31, 2022
small rustc_borrowck cleanup r? `@jackh726` because of the second commit, seems like that comment was missed in rust-lang#91243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of #88312
r? @pnkfelix
cc @nikomatsakis