Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Option::as_mut const #89953

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Make Option::as_mut const #89953

merged 2 commits into from
Oct 17, 2021

Conversation

lilasta
Copy link
Contributor

@lilasta lilasta commented Oct 16, 2021

Adding const for Option::as_mut.

Tracking issue: #67441

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2021
@rust-log-analyzer

This comment has been minimized.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 16, 2021

@bors r+ rollup

r? @oli-obk

@bors
Copy link
Contributor

bors commented Oct 16, 2021

📌 Commit d1f7608 has been approved by oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned kennytm Oct 16, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 16, 2021
Make Option::as_mut const

Adding `const` for `Option::as_mut`.

Tracking issue: rust-lang#67441
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2021
Rollup of 7 pull requests

Successful merges:

 - rust-lang#89507 (Add `#[repr(i8)]` to `Ordering`)
 - rust-lang#89849 (CI: Selecting the Xcode version no longer needed with the macos-11 runners.)
 - rust-lang#89886 (Update the wasi-libc built with the wasm32-wasi target)
 - rust-lang#89907 (Remove FIXME since there is nothing to be fixed)
 - rust-lang#89943 (clippy::complexity fixes)
 - rust-lang#89953 (Make Option::as_mut const)
 - rust-lang#89958 (Correct small typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0029af7 into rust-lang:master Oct 17, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 17, 2021
@lilasta lilasta deleted the option_const_as_mut branch December 25, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants